SGA-13064: Query parsing failed due to casting to text(n)#2
Closed
SGA-13064: Query parsing failed due to casting to text(n)#2
Conversation
yoavcloud
commented
Apr 6, 2026
| } | ||
| Keyword::TEXT => Ok(DataType::Text), | ||
| Keyword::TEXT => { | ||
| if dialect_is!(dialect is SnowflakeDialect) |
Owner
Author
There was a problem hiding this comment.
Remove this condition, it's safe to run on all dialects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira issue: SGA-13064
Prepared by agent-sqlparser-coder.
Adjusted Snowflake type parsing so
TEXT(...)consumes its parenthesized modifier instead of leaving(behind after a::cast. The fix is in src/parser/mod.rs, where SnowflakeTEXT(n)now parses as a custom type form while plainTEXTstill staysDataType::Text.Added focused regressions in tests/sqlparser_snowflake.rs: one for
_ID::TEXT(16777216)and one forCREATE TABLE ... TEXT(16777216)alongside plainTEXT.Validation passed:
cargo fmt --allCARGO_HOME=/tmp/cargo-home cargo test --offline --all-featuresCARGO_HOME=/tmp/cargo-home cargo clippy --all-targets --all-features -- -D warningsCARGO_HOME=/tmp/cargo-home cargo doc --document-private-items --no-deps --workspace --all-featuresCommitted as
4a3e8cabwith messageSupport Snowflake TEXT(n) casts. Worktree is clean and ready to push.